Merged
Conversation
…ner bezel User feedback on #76: sizing was correct but the device still looked melted into the cream canvas, the bezel was thick enough to clip iframe content, and the notch read as a bump rather than a real iPhone cut-out. Changes: - New tokens (--color-phone-body / --color-phone-island / --border-width-phone-bezel / --size-preview-mobile-island-{w,h}), light + dark variants - Single-layer deep space-gray body (no more outer cream + inner black double bezel) with a 3px bezel so artifact corners are not eaten - Centered Dynamic Island pill replaces the notch - Hide the click-to-comment hint pill in mobile viewport — it was overlapping the device chrome and the user has already opted into the small frame - Test contract updated: asserts body uses dedicated phone token (not --color-surface / --color-background) and exposes a stable test id + island token names
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Findings
- No high-confidence issues found on added/modified lines.
Summary
- Review mode: initial
- No actionable issues detected in this diff.
- Residual risks/testing gaps:
docs/VISION.mdanddocs/PRINCIPLES.mdare not present in this checkout (Not found in repo/docs), so project-principle alignment could not be fully verified from those docs alone.
Testing
- Not run (automation)
open-codesign Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
用户反馈 #76 修了 PhoneFrame 尺寸但视觉仍丑：
What
--color-phone-body（深 space gray）+--color-phone-island（接近纯黑）+--border-width-phone-bezel: 3px+--size-preview-mobile-island-{w,h}，亮/暗主题各一份PhoneFrame.tsx重写：单层 deep-gray body（明确不复用--color-surface）+ 3px 薄 bezel + 居中 Dynamic Island pill 取代 notch；屏幕圆角 =radius-phone − bezel，artifact 边缘不再被切PreviewPane.tsx：mobile viewport 不渲染 click-to-comment hint pill（用户已切到小屏，提示反而挡设备 chrome）Tests
pnpm typecheck✅pnpm --filter @open-codesign/desktop exec vitest run→ 25 files / 231 tests ✅（含新增 PhoneFrame 5 tests）pnpm exec biome check（变更文件） ✅Constraints