Fix IndexError in pipeline registry when allowed_prompts is empty#28
Merged
MOLYHECI merged 1 commit intoOpenDCAI:backendfrom Dec 28, 2025
Merged
Fix IndexError in pipeline registry when allowed_prompts is empty#28MOLYHECI merged 1 commit intoOpenDCAI:backendfrom
MOLYHECI merged 1 commit intoOpenDCAI:backendfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an IndexError that occurs in the pipeline registry when the allowed_prompts list is empty or None. The fix adds a conditional check before accessing the first element of the list.
Key Changes:
- Added a guard condition to check if
allowed_promptsexists and is non-empty before accessing index 0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+804
to
+805
| if op_details.get("allowed_prompts"): | ||
| p_val = op_details["allowed_prompts"][0] |
There was a problem hiding this comment.
The fix to prevent IndexError when allowed_prompts is empty is correct, but there's no test coverage for this edge case. Consider adding a test that verifies the behavior when an operator has an empty allowed_prompts list to ensure this IndexError scenario is properly covered and won't regress in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.