feat: save pipeline config snapshot in async task execution and exposure in status API#35
Conversation
…ure in status API
There was a problem hiding this comment.
Pull request overview
This PR enhances task execution tracking by exposing pipeline configuration snapshots in the status API. The changes ensure that pipeline_id and pipeline_config are captured at execution time and made available through status and result queries.
Key Changes:
- Added pipeline_id and pipeline_config fields to async execution initialization
- Exposed pipeline_id and pipeline_config in get_execution_status API response
- Exposed pipeline_id and pipeline_config in get_execution_result API response
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "pipeline_id": execution_data.get("pipeline_id"), | ||
| "pipeline_config": execution_data.get("pipeline_config"), |
There was a problem hiding this comment.
The newly added pipeline_id and pipeline_config fields in the status response lack test coverage. Consider adding test cases to verify these fields are correctly returned by get_execution_status, especially when they are present or absent in the execution data.
| "pipeline_id": execution_data.get("pipeline_id"), | ||
| "pipeline_config": execution_data.get("pipeline_config"), |
There was a problem hiding this comment.
The newly added pipeline_id and pipeline_config fields in the result response lack test coverage. Consider adding test cases to verify these fields are correctly returned by get_execution_result, especially when they are present or absent in the execution data.
| "pipeline_id": pipeline_id, | ||
| "pipeline_config": pipeline_config, |
There was a problem hiding this comment.
The newly added pipeline_id and pipeline_config fields in the initial_result lack test coverage. Consider adding test cases to verify these fields are correctly stored when starting async execution, especially to confirm they match the input parameters.
|
LGTM. Thanks! |
…ure in status API