- 
                Notifications
    
You must be signed in to change notification settings  - Fork 99
 
[Update] Merging and renaming text2qa op #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           这个要不要和 @ZhaoyangHan04 核对一下,他的那边也改一下一起在这个PR里面合并? @ZhaoyangHan04 可以朝wong哥的branch提PR。  | 
    
multihopqa to core by hzy
          
 Done  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Prompt那块还是麻烦兄弟们清理一下。 @ZhaoyangHan04 确认一下这个是batch的行为改完的版本,还是后面batch会单独提一个pr修改。
        
          
                dataflow/prompts/multihopqa.py
              
                Outdated
          
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件合并到text2qa,类名前缀加上Text2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
batch会继续交到这个pr 请延后merge thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
batch会继续交到这个pr 请延后merge thx!
Received, thanks!
add batch support to kbc regular ops
mineru2.5 adaptation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks, bro!
No description provided.