Samples from a DynamicDataReader are immutable#4609
Merged
jrw972 merged 1 commit intoOpenDDS:masterfrom May 6, 2024
Merged
Conversation
jrw972
force-pushed
the
dynamic-read-modify-write
branch
2 times, most recently
from
9128d11 to
dde30ca
Compare
mitza-oci
reviewed
May 1, 2024
iguessthislldo
requested changes
May 1, 2024
jrw972
force-pushed
the
dynamic-read-modify-write
branch
2 times, most recently
from
50040cf to
8d4f438
Compare
iguessthislldo
approved these changes
May 2, 2024
Problem ------- Users cannot read a sample from a DynamicDataReader, modify it, and then write it. Solution -------- Update the DynamicSample implementation to use DynamicDataImpl with a DynamicDataXcdrReadImpl backing store.
jrw972
force-pushed
the
dynamic-read-modify-write
branch
from
8d4f438 to
5a08a05
Compare
iguessthislldo
approved these changes
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users cannot read a sample from a DynamicDataReader, modify it, and then write it.
Solution
Update the DynamicSample implementation to use DynamicDataImpl with a DynamicDataXcdrReadImpl backing store.