feat: Change .STL viewer and samples to +Z=Up #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Great, thanks a lot. Hopefully we can somehow accommodate this information for the preparation of the data during the upload. I don't know how to do it now, though. |
Collaborator
Author
That's a good point, following up about this at https://phabricator.wikimedia.org/T246901#10362412. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For backward compatibility with the production STL viewer, restores a +Z=Up to +Y=Up conversion for STL models only. For glTF we assume models are already +Y=Up, as required by the specification.
For each STL model that wasn't +Z=Up default (most were +Y=Up) I re-oriented them in Blender, first importing with
-X=Front, +Y=Upin the importer settings, and then exporting with +Z=Up and whichever front-facing direction looked reasonable.