Dockerize#6
Conversation
| proxy_set_header X-Real-IP $remote_addr; | ||
| proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; | ||
| proxy_set_header X-NginX-Proxy true; | ||
| proxy_pass http://girder/api/; |
There was a problem hiding this comment.
Is nginx also proxying girder? so I am wondering if we need to set the cors stuff.
There was a problem hiding this comment.
I just took the config that Brandon did. I think we still need cors stuff.
| sleep 10 | ||
| python3 /home/provision/girder.py | ||
| cd /home/data && python3 ingest.py ./data girder 8080 admin letmein | ||
| cd /home/data && python3 ingest_1000.py ./data girder 8080 admin letmein |
There was a problem hiding this comment.
We probably don't need to provision each time we start the container, right? Maybe just leave them out and run them manually?
There was a problem hiding this comment.
The scripts are idempotent so running it multiple times is quick and yields the same result. I wanted to do everything as part of docker deployment so that we do not have to run manual steps. I don't have a preference this just seemed easier for deployment :).
There was a problem hiding this comment.
The data ingestion is kind of two heavy as part of the startup. I am thinking that data is not part of application. I think we will have more data, we don't want to always copy them to the docker image. The beauty of girder client-based data ingestion is that we can run it from anywhere and the original data don't have to be exists on the server.
There was a problem hiding this comment.
Ok, I can make that change so that ingest scripts are not part of provisioning but a post provisioning step that we do manually. I will make that change soon.
There was a problem hiding this comment.
Cool! and all the parameterize work is useful either way.
There was a problem hiding this comment.
@matthewma7 I addressed your comment. PTAL
2 participants
No description provided.