Skip to content

feat(formulus): update to use react-native-camera-kit-no-google …#582

Merged
najuna-brian merged 1 commit intoOpenDataEnsemble:devfrom
HelloSapiens:feature/replace-closed-source-ml-lib
Mar 28, 2026
Merged

feat(formulus): update to use react-native-camera-kit-no-google …#582
najuna-brian merged 1 commit intoOpenDataEnsemble:devfrom
HelloSapiens:feature/replace-closed-source-ml-lib

Conversation

@r0ssing
Copy link
Copy Markdown
Contributor

@r0ssing r0ssing commented Mar 28, 2026

Update to use react-native-camera-kit-no-google

Description

…and improve error handling

  • Renamed VisionCameraErrorBoundary to QRScannerErrorBoundary for clarity.
  • Updated error messages and fallback content to reflect the new camera module.
  • Removed VisionCamera code scanner references from build.gradle and gradle.properties.
  • Enhanced QRScannerModalImpl to handle camera permissions and scanning logic with the new library.
  • Improved user feedback during permission checks and scanning process.

Type of Change

  • Bug Fix
  • New Feature / Enhancement
  • Refactor / Code Cleanup
  • Documentation Update
  • Maintenance / Chore
  • Other (please specify):

Component(s) Affected

  • formulus (React Native mobile app)
  • formulus-formplayer (React web app)
  • synkronus (Go backend server)
  • synkronus-cli (Command-line utility)
  • Documentation
  • DevOps / CI/CD
  • Other:

Related Issue(s)

Closes #581


Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manually tested
  • Tested on multiple platforms (if applicable)
  • Not applicable

Breaking Changes

  • This PR introduces breaking changes
  • This PR does NOT introduce breaking changes

If breaking changes, please describe migration steps:

This PR does introduce a breaking change in that it removes the undocumented functionality of the previous scanner lib to scan other types of barcodes. However - since that was undocumented, I recommend we implement this fix as a patch release anyway.

Documentation Updates

  • Documentation has been updated
  • Documentation update is not required

Checklist

  • Code follows project style guidelines
  • All existing tests pass
  • New tests added for new functionality
  • PR title follows Conventional Commits format

Thank you for contributing to Open Data Ensemble (ODE)!

…and improve error handling

- Renamed VisionCameraErrorBoundary to QRScannerErrorBoundary for clarity.
- Updated error messages and fallback content to reflect the new camera module.
- Removed VisionCamera code scanner references from build.gradle and gradle.properties.
- Enhanced QRScannerModalImpl to handle camera permissions and scanning logic with the new library.
- Improved user feedback during permission checks and scanning process.
@r0ssing r0ssing requested a review from najuna-brian March 28, 2026 08:52
Copy link
Copy Markdown
Contributor

@najuna-brian najuna-brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@najuna-brian najuna-brian merged commit a7e3425 into OpenDataEnsemble:dev Mar 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[formulus] Replace closed-source camera lib

2 participants