Skip to content

refactor(formulus): subObservationMode naming follow-up#604

Closed
Mishael-2584 wants to merge 0 commit intodevfrom
chore/sub-observation-naming-followup
Closed

refactor(formulus): subObservationMode naming follow-up#604
Mishael-2584 wants to merge 0 commit intodevfrom
chore/sub-observation-naming-followup

Conversation

@Mishael-2584
Copy link
Copy Markdown
Contributor

@Mishael-2584 Mishael-2584 commented Apr 14, 2026

Summary

Follow-up to PR #591 / review: rename embedded child-form flag from
eturnOnly\ to \subObservationMode\ on \FormInitData\ and \openFormplayer\ options.

Changes

  • Contract: [\FormulusInterfaceDefinition.ts](formulus/src/webview/FormulusInterfaceDefinition.ts) - \subObservationMode\ replaces
    eturnOnly.
  • Native: [\App.tsx](formulus/App.tsx), [\FormplayerModal.tsx](formulus/src/components/FormplayerModal.tsx), [\FormulusMessageHandlers.ts](formulus/src/webview/FormulusMessageHandlers.ts) - wire-through + legacy
    eturnOnly\ acceptance on bridge payloads.
  • Formplayer: [\App.tsx](formulus-formplayer/src/App.tsx) - \isSubObservationSession\ helper (legacy
    eturnOnly\ on init), merged draft-session nulling per review; synced interface types.

Notes


  • pm run generate\ in formulus failed locally (Node/ts-node ESM); injection still forwards opaque \options\ - native handler accepts both keys.
  • \ ormplayer_dist\ is gitignored; run
    pm run build:rn\ in formulus-formplayer before release builds.

Closes follow-up from review thread on #591.

@Mishael-2584 Mishael-2584 force-pushed the chore/sub-observation-naming-followup branch from 0c2a6fe to 3cffb1d Compare April 14, 2026 21:57
@Mishael-2584 Mishael-2584 force-pushed the chore/sub-observation-naming-followup branch from 3cffb1d to ca58848 Compare April 14, 2026 22:02
@Mishael-2584 Mishael-2584 deleted the chore/sub-observation-naming-followup branch April 14, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant