refactor: rename returnOnly to subObservationMode for clarity in form handling#605
Merged
najuna-brian merged 1 commit intodevfrom Apr 14, 2026
Merged
refactor: rename returnOnly to subObservationMode for clarity in form handling#605najuna-brian merged 1 commit intodevfrom
najuna-brian merged 1 commit intodevfrom
Conversation
najuna-brian
approved these changes
Apr 14, 2026
Contributor
najuna-brian
left a comment
There was a problem hiding this comment.
Confirmed working
Thanks @Mishael-2584

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to the sub-observation / embedded child-form work: rename the init and
openFormplayerflag fromreturnOnlytosubObservationMode, tidy formplayer draft handling, and drop noisy logging on the no–persist path.What changed
FormInitDataandopenFormplayeroptions usesubObservationMode?: boolean(seeformulus/src/webview/FormulusInterfaceDefinition.ts).App.tsx,FormplayerModal.tsx, andFormulusMessageHandlers.tspass/read the new field;formInitDatausessubObservationMode.returnOnly(top-level or underoptions) are still honored for one transition period.App.tsxusessubObservationModeand merges the draft-session reset whensubObservationMode || observationId != null(with the same legacy read where applicable).console.loginFormplayerModalfor the path that does not save to the DB.Files touched (high level)
App.tsx,src/components/FormplayerModal.tsx,src/webview/FormulusInterfaceDefinition.ts,src/webview/FormulusMessageHandlers.tssrc/App.tsx,src/types/FormulusInterfaceDefinition.ts(vianpm run sync-interface)How to verify
returnOnly(if you have one) to confirm it still works.Notes
npm run sync-interface(and your usualnpm run build:rninformulus-formplayerif you ship RN-bundled assets) before merging or releasing.npm run generatefor the WebView injection script fails in your environment, it is separate from this rename; native handling ofoptionsis what matters for the new key.