-
Notifications
You must be signed in to change notification settings - Fork 8
Patch dependencies to the latest #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- patch other dependencies to the latest Signed-off-by: Jessie Ssebuliba <jessiessebuliba@gmail.com>
|
Thanks @Jexsie |
|
Thanks @Jexsie for being proactive about security! 🙏 I've had a look like the React security advisory and our codebase, and it looks like our codebase is not directly affected by CVE-2025-55182. The vulnerability specifically affects:
These packages are only used with React Server Components (RSC), which we don't use in any of our projects:
As stated in the advisory: "If your app's React code does not use a server, your app is not affected by this vulnerability." What do you think? |
najuna-brian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About This PR, the changes in this PR are good but may be not directly linked to the security vulnerability?
- React update (
19.0.0→19.2.3): The vulnerability isn't in React core, so this doesn't fix it? - React Native upgrade (
0.79.2→0.83.0): This is a major version jump (4 minor versions) that we can hopefully do later following good migration guides - Other dependency updates are actually good as well.
Thanks again for being security-conscious! This is really key to keeping our project running securely
|
Thanks a lot for pointing this out. I agree that we're not directly affected. However perhaps this is an opportunity to consider implementing static code analysis and regular dependency checks (like dependabot) into our CI/CD setup? |
|
Great suggestion! I agree, we could look into setting up Dependabot for automated dependency checks. I see we can enable it directly in GitHub Settings, and then add a config file later for more control over schedules and grouping? @Jexsie - since you're already thinking about dependency management, would you be interested in writing the Dependabot config file? |
Currently most are minor version bumps, the critical to look at might be; |
I would suggest we first handle package upgrade then add the dependatbot in a follow up issue. And yeah, am ready to handle that @najuna-brian, if no one is willing to take it up |
|
That sounds like a great approach! Thank you so much |
Thanks @r0ssing for highlighting this (it’s something I’ve also been considering). Given that we’re working in a monorepo setup, I would strongly recommend using Renovate over Dependabot, as Renovate provides more advanced functionality and finer-grained control for managing dependencies in monorepos. https://dev.to/alex_aslam/renovate-vs-dependabot-which-bot-will-rule-your-monorepo-4431 |
Patch dependencies to the latest following the latest react vulnerability https://react.dev/blog/2025/12/03/critical-security-vulnerability-in-react-server-components