Fixed writing to OTP registers smaller than 32 bits#26
Merged
JamesHuard merged 1 commit intoOpenDevicePartnership:mainfrom Oct 7, 2025
Merged
Conversation
JamesHuard
approved these changes
Oct 7, 2025
ayodejiige
approved these changes
Oct 7, 2025
gjpmsft
approved these changes
Oct 7, 2025
jerrysxie
reviewed
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a single device-driver definition of the OTP fuse registers, but can access them both from shadow registers, as well as from the OTP ROM API. In the OTP ROM API implementation writing to registers smaller than 32 bits did not do anything. See #25.
This is due to calling
chunks_exactwith a size of 4, which does not yield any chunk if the remaining buffer cannot fit exactly that chunk:ec-slimloader/libs/imxrt-rom/src/registers.rs
Lines 114 to 119 in 76d6f5c
This PR streamlines how the OTP words are accessed between OTP ROM API and shadow registers, and adds a few tests to validate that it does so correctly.