Migrate embassy crates to latest on crate.io #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo Vet Audit Passed
|
JamesHuard
previously approved these changes
Aug 29, 2025
asasine
previously approved these changes
Aug 29, 2025
felipebalbi
previously approved these changes
Aug 29, 2025
jerrysxie
dismissed stale reviews from felipebalbi, asasine, and JamesHuard
via
faa1222
jerrysxie
requested review from
JamesHuard,
asasine,
gjpmsft and
madeleyneVaca
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates embassy crates from git dependencies to their latest published versions on crates.io. This is a dependency update that standardizes the project to use stable, published releases instead of git references.
- Replaces git dependencies with version-specific crates.io dependencies for all embassy crates
- Updates to the latest available versions (embassy-sync 0.7.2, embassy-executor 0.9.0, etc.)
- Maintains all existing feature configurations
Reviewed Changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Updates workspace-level embassy dependencies from git to crates.io versions |
| examples/std/Cargo.toml | Migrates embassy dependencies for the std example |
| examples/rt685s-evk/Cargo.toml | Migrates embassy dependencies for the rt685s-evk example |
| examples/rt633/Cargo.toml | Migrates embassy dependencies for the rt633 example |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JamesHuard
approved these changes
Aug 29, 2025
jeffglaum
approved these changes
Aug 29, 2025
asasine
reviewed
Aug 29, 2025
Comment on lines
555
to
579
| [[package]] | ||
| name = "embassy-executor" | ||
| version = "0.8.0" | ||
| source = "git+https://github.com/embassy-rs/embassy#ef673c6ca310cf0a7e9b1254afb7806bd6879e94" | ||
| version = "0.7.0" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "90327bcc66333a507f89ecc4e2d911b265c45f5c9bc241f98eee076752d35ac6" | ||
| dependencies = [ | ||
| "critical-section", | ||
| "document-features", | ||
| "embassy-executor-macros 0.6.2", | ||
| ] | ||
|
|
||
| [[package]] | ||
| name = "embassy-executor" | ||
| version = "0.9.0" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "d0c80c92a31c7f6b02a938f10feea17ea3cc0e8d33bcac7f3fe8cede3723bb56" | ||
| dependencies = [ | ||
| "cortex-m", | ||
| "critical-section", | ||
| "defmt 1.0.1", | ||
| "document-features", | ||
| "embassy-executor-macros", | ||
| "embassy-executor-macros 0.7.0", | ||
| "embassy-executor-timer-queue", | ||
| "log", | ||
| ] |
There was a problem hiding this comment.
Can we sort out the double embassy-executor dependency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.