Fix charge fail issue of hotplug dock on same port #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a charge failure issue when hot-plugging a dock on the same port by ensuring the consumer state is properly cleared during device detach events. The previous logic conditionally skipped consumer state updates when a provider was detached, which caused the consumer to not be cleared when it should have been.
Key changes:
- Removed conditional logic in
process_notify_detachthat prevented consumer updates when a provider was detached - Changed to always call
update_current_consumer()after removing a provider, ensuring consumer state is recalculated regardless of the detached device type
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RobertZ2011
approved these changes
Dec 2, 2025
tullom
approved these changes
Dec 2, 2025
tullom
added a commit
that referenced
this pull request
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumer device is not cleared on detach when there is connected provider