power-policy-service: Shorten lock held in disconnect flow#813
Merged
RobertZ2011 merged 1 commit intoApr 21, 2026
Conversation
This lock was being held for the duration of the conditional branch, causing a deadlock in `update_current_consumer`.
RobertZ2011
force-pushed
the
power-policy-disconnect-dont-hold-lock
branch
from
5b63c14 to
50405a2
Compare
RobertZ2011
requested review from
asasine,
chchongmsft,
felipebalbi,
gjpmsft,
jerrysxie,
seanbrns,
thdesil and
tullom
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the power-policy-service disconnect handling to avoid holding the internal mutex across async work, preventing a deadlock when update_current_consumer() is invoked during the disconnect flow.
Changes:
- Refactor
process_notify_disconnectto extractcurrent_consumer_stateunder the mutex, then drop the lock before running the disconnect/update sequence.
jerrysxie
approved these changes
Apr 21, 2026
chchongmsft
approved these changes
Apr 21, 2026
jerrysxie
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lock was being held for the duration of the conditional branch, causing a deadlock in
update_current_consumer.