Fleshing out more planned EC services and platform abstractions #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrysxie
force-pushed
the
ec-services-fleshing-out
branch
from
a4296e9 to
071df4e
Compare
jerrysxie
requested review from
JamesHuard,
RobertZ2011,
felipebalbi and
madeleyneVaca
as code owners
JamesHuard
approved these changes
Jan 23, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
README.md:142
- The term 'I2c' should be 'I2C' to maintain consistency.
HID over I2c transport
README.md:223
- [nitpick] The term 'embassy-imxrt' should be capitalized as 'Embassy-IMXRT' to maintain naming consistency.
class FlexSPI["embassy-imxrt FlexSPI HAL"]
felipebalbi
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.