Update embedded-services + hals#16
Open
kurtjd wants to merge 3 commits into
Open
Conversation
kurtjd
force-pushed
the
update-embedded-services
branch
from
9a85894 to
38d6ff4
Compare
Cargo Vet Audit Passed
|
There was a problem hiding this comment.
Pull request overview
This PR updates the firmware’s OpenDevicePartnership embedded-services dependency set (including uart-service moving to embedded-io-async v0.7) and aligns platform HAL usage to remove now-unnecessary UART adapter/wrapper layers.
Changes:
- Bump
platform-commonto explicitly includeembedded-io/embedded-io-asyncv0.7 to match the updated service stack. - Update
dev-npcxanddev-mcxato pass HAL UART instances directly intouart-servicetasks (removing wrapper/adapter code). - Refresh per-platform lockfiles to the new
embedded-services+ HAL revisions.
Reviewed changes
Copilot reviewed 6 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| platform/platform-common/Cargo.toml | Adds embedded-io/embedded-io-async v0.7 dependencies to align with updated services. |
| platform/platform-common/Cargo.lock | Lockfile refresh for updated embedded-services revision and dependency graph. |
| platform/dev-qemu/Cargo.lock | Lockfile refresh for updated embedded-services + embassy-qemu-riscv revision and embedded-io(-async) v0.7. |
| platform/dev-npcx/src/main.rs | Updates UART task signature to accept the HAL UART directly (no wrapper). |
| platform/dev-npcx/src/board.rs | Removes UART wrapper and exposes uart::Uart directly from the board. |
| platform/dev-npcx/Cargo.lock | Lockfile refresh reflecting updated dependencies (still shows embedded-io-async v0.6 pulled in). |
| platform/dev-mcxa/src/uart_adapter.rs | Deletes the v0.6 compatibility adapter (no longer needed with v0.7 services). |
| platform/dev-mcxa/src/main.rs | Updates UART task to use lpuart::LpuartBbq directly and removes adapter usage. |
| platform/dev-mcxa/Cargo.toml | Updates embassy-mcxa revision and removes explicit v0.6 embedded-io(-async) compatibility deps. |
| platform/dev-mcxa/Cargo.lock | Lockfile refresh for updated embassy revision + service stack changes. |
| platform/dev-imxrt/meta_err.txt | Adds/keeps an empty file in the repo (appears to be an artifact). |
| platform/dev-imxrt/Cargo.lock | Lockfile refresh for updated embedded-services + embassy-imxrt revision and embedded-io(-async) v0.7 additions. |
tullom
previously approved these changes
May 13, 2026
…cies Assisted-by: copilot-cli:claude-opus-4.6 cargo-vet
kurtjd
force-pushed
the
update-embedded-services
branch
from
e383261 to
5187bdf
Compare
Contributor
Author
|
Used: https://github.com/OpenDevicePartnership/embedded-services/blob/main/.github/skills/cargo-vet-audit/SKILL.md |
jerrysxie
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently updated
uart-serviceto use v7 ofembedded-io-asyncso updateembedded-serviceshere to pull in those changes. Additionally had to make several changes to all the HALs (embassy-imxrt, embassy-mcxa, embassy-npcx, and embassy-qemu-riscv) to clean some things up (like updating those hals to impl v7 and implementing the traits for unsplit uart instances).This allows some cleanup here such as removing all the uart wrappers.