Make embedded-sensors and async optional #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of unconditionally adding embedded-hal-async and embedded-sensors, let the user decide if they need it. Signed-off-by: Felipe Balbi <febalbi@microsoft.com>
felipebalbi
requested review from
RobertZ2011,
jerrysxie and
tullom
as code owners
Contributor
Author
|
CI fails due to |
jerrysxie
approved these changes
Feb 26, 2025
RobertZ2011
approved these changes
Feb 26, 2025
felipebalbi
merged commit 9920e33
into
OpenDevicePartnership:main
3 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of unconditionally adding embedded-hal-async and embedded-sensors, let the user decide if they need it.