Skip to content

fix(ci): pass BUILD_VERSION as string to avoid float formatting issue#12

Merged
jonasniesner merged 1 commit intoOpenDisplay:mainfrom
andreasbrett:patch-1
Mar 22, 2026
Merged

fix(ci): pass BUILD_VERSION as string to avoid float formatting issue#12
jonasniesner merged 1 commit intoOpenDisplay:mainfrom
andreasbrett:patch-1

Conversation

@andreasbrett
Copy link
Copy Markdown
Contributor

@andreasbrett andreasbrett commented Mar 22, 2026

BUILD_VERSION was interpreted as a float instead of a string when injected via CI build flags before.

This caused values like 1.1 to be treated as a floating-point literal (1.1) rather than a string ("1.1"). When converted using String(BUILD_VERSION), this then resulted in incorrect version formatting (e.g. "1.10"). It's used in getFirmwareMajor and getFirmwareMinor.

Firmware/src/main.cpp

Lines 573 to 580 in b04a22b

uint8_t getFirmwareMajor(){
String version = String(BUILD_VERSION);
int dotIndex = version.indexOf('.');
if (dotIndex > 0) {
return version.substring(0, dotIndex).toInt();
}
return 0;
}

Firmware/src/main.cpp

Lines 582 to 589 in b04a22b

uint8_t getFirmwareMinor(){
String version = String(BUILD_VERSION);
int dotIndex = version.indexOf('.');
if (dotIndex > 0 && dotIndex < (int)(version.length() - 1)) {
return version.substring(dotIndex + 1).toInt();
}
return 0;
}

@jonasniesner
Copy link
Copy Markdown
Member

Thank you for your PR

@jonasniesner jonasniesner merged commit 779f21b into OpenDisplay:main Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants