fix: move WiFi handling after BLE command queue processing#30
Merged
jonasniesner merged 1 commit intoMay 28, 2026
Merged
Conversation
In v1.6, handleWiFiServer() and the WiFi reconnection check were moved to the top of loop(), before BLE command/response queue processing. This can cause BLE commands to sit unprocessed in the queue when handleWiFiServer() blocks or takes a slow path, resulting in BLE timeouts for clients (Home Assistant integration, py-opendisplay). Observed symptoms: - BLE READ CONFIG commands queued but never processed - 'ESP32: Command queued for processing' appears in serial log but 'ESP32: Processing queued command' never follows - Home Assistant integration fails with 'ble_timeout' during device interrogation - py-opendisplay image uploads timeout after 10s This commit moves WiFi handling back to after the BLE command queue drain and response notification loop, restoring the v1.3 execution order where BLE is always serviced first. WiFi functionality is preserved — only the ordering within the loop iteration changes. Co-Authored-By: Oz <oz-agent@warp.dev>
Member
|
I dont know how this will help, but it looks like it wont have downsides so I will merge it anyways |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In v1.6,
handleWiFiServer()and the WiFi reconnection check were moved to the top ofloop(), before BLE command/response queue processing. This can cause BLE commands to sit unprocessed in the queue whenhandleWiFiServer()blocks or takes a slow path, resulting in BLE timeouts for clients.Symptoms observed on EE04 (ESP32-S3) + 7.3" Spectra 6
ESP32: Command queued for processingappears in serial log butESP32: Processing queued commandnever followsble_timeoutduring device interrogationFix
Move
handleWiFiServer()and WiFi reconnection check to after the BLE command queue drain and response notification loop, restoring the v1.3 execution order where BLE is always serviced first. WiFi functionality is unchanged — only the ordering within the loop changes.Testing
infocommand)uploadcommand)Co-Authored-By: Oz oz-agent@warp.dev