refactor: Migrate BLE device connection and operations to py-opendisplay#35
Open
stuart-c-ai wants to merge 4 commits into
Open
refactor: Migrate BLE device connection and operations to py-opendisplay#35stuart-c-ai wants to merge 4 commits into
stuart-c-ai wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR Dependency
Important
This Pull Request represents Stage 2 of our sequential migration to the new
py-opendisplayBLE library. It depends on and includes the changes from Stage 1.Please ensure that PR #34: refactor: Deprecate ATC (OpenEPaperLink) protocol and simplify entity structure is merged before this PR is reviewed or merged.
Description & Goal
The goal of this stage is to port BLE device connection management and core operational commands to the official
py-opendisplay==7.3.0client library. It replaces our legacy localBLEConnectionclass and its custom exception handling routines with the library's nativeOpenDisplayDeviceinterface and exceptions.By migrating the connection logic in this isolated stage, we ensure that connection establishment and device commands are fully validated before refactoring the more complex image upload pipelines in subsequent stages.
What was Done & Why
1. Exception Handling Modernization
config_flow.py,button.py,services.py,upload.pyBLEConnectionError,BLETimeoutError, andBLEProtocolError) with their standardpy-opendisplayequivalents imported fromopendisplay.exceptions:BLEConnectionErrorBLETimeoutErrorProtocolError2. Connection Block Refactoring
config_flow.py,button.py,services.pyasync with BLEConnection(...)context blocks with the library's nativeasync with OpenDisplayDevice(mac_address=...)contexts.3. Device Interrogation & Configuration Refresh
config_flow.py,button.pyconn.interrogate()andconn.read_firmware_version()into the setup and configuration refresh flows. This queries capabilities and system settings directly from the display and parses them into standard model fields.4. Core Operational Commands Porting
services.py,button.pyconn.activate_led()conn.reboot()