Feature/Implement ESS Delayed Sell-To-Grid Controller#1246
Merged
huseyinsaht merged 17 commits intodevelopfrom Oct 6, 2020
Merged
Feature/Implement ESS Delayed Sell-To-Grid Controller#1246huseyinsaht merged 17 commits intodevelopfrom
huseyinsaht merged 17 commits intodevelopfrom
Conversation
* States added, to make it clear and easier debug * Calculated power channel added for UI widget
# Conflicts: # io.openems.edge.controller.ess.delayedselltogrid/src/io/openems/edge/controller/ess/delayedselltogrid/DelayedSellToGrid.java # io.openems.edge.controller.ess.delayedselltogrid/src/io/openems/edge/controller/ess/delayedselltogrid/DelayedSellToGridImpl.java # io.openems.edge.controller.ess.delayedselltogrid/test/io/openems/edge/controller/ess/delayedselltogrid/DelayedSellToGridImplTest.java # io.openems.edge.controller.ess.delayedselltogrid/test/io/openems/edge/controller/ess/delayedselltogrid/TestDelayedSellToGrid.java
* Test cases changed in order to test state machine and set power * Calculatedpower Method Test file deleted [method not exist anymore]
pooran-c
approved these changes
Oct 6, 2020
huseyinsaht
commented
Oct 6, 2020
Contributor
Author
huseyinsaht
left a comment
huseyinsaht
left a comment
There was a problem hiding this comment.
Thanks for improving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.