Update MyModbusDeviceImpl.java#3315
Merged
sfeilmeier merged 2 commits intoOpenEMS:developfrom Oct 8, 2025
Merged
Conversation
removed exception, as method signature didn't match abstract base class anymore
Contributor
Author
|
Creating a new component via Eclipse leads to an error. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3315 +/- ##
===========================================
- Coverage 26.53% 26.48% -0.04%
===========================================
Files 320 320
Lines 8641 8641
Branches 1334 1334
===========================================
- Hits 2292 2288 -4
- Misses 6245 6251 +6
+ Partials 104 102 -2 🚀 New features to boost your workflow:
|
removed old exception in documentation as well.
michaelgrill
approved these changes
Sep 18, 2025
Contributor
michaelgrill
left a comment
michaelgrill
left a comment
There was a problem hiding this comment.
looks good, thanks👍
Contributor
Author
|
@sfeilmeier this (and #3318) should be a quick one. :) |
sfeilmeier
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed exception, as method signature didn't match abstract base class anymore