Skip to content

Added docker-compose.yml and enhanced documentation to get a just a UI for development#3430

Merged
sfeilmeier merged 12 commits intoOpenEMS:developfrom
janklostermann:develop
Nov 24, 2025
Merged

Added docker-compose.yml and enhanced documentation to get a just a UI for development#3430
sfeilmeier merged 12 commits intoOpenEMS:developfrom
janklostermann:develop

Conversation

@janklostermann
Copy link
Copy Markdown
Contributor

The purpose of this enhancement is simplifying the getting started for people who want to develop just edge, and need an easy way to get a UI up and running. With the docker-compose.yml a container with the UI can be created and spun-up, all network configuration prepared for development on the local host machine. All details around it are explained in the documentation file. I just extended the existing page under deploy with docker for edge (where the documentation on getting the UI via docker leads to).
If you feel there are better places for this stuff, feel free to move it, but be aware that there are references to the doc-file elsewhere.

Copy link
Copy Markdown
Contributor

@da-Kai da-Kai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @janklostermann,
thanks for your PR.
I had originally omitted docker-compose files for hosting just the UI, as i didn’t see a clear use case. If this setup supports your development, it’s certainly valuable to include.
I am just not sure about the current placement of the docs and files.

Comment thread doc/modules/ROOT/pages/edge/deploy/docker.adoc Outdated
Comment thread tools/docker/ui/docker-compose.yml
@janklostermann
Copy link
Copy Markdown
Contributor Author

janklostermann commented Nov 20, 2025 via email

@da-Kai
Copy link
Copy Markdown
Contributor

da-Kai commented Nov 21, 2025

Hi @janklostermann,

Are you aware of other links on how to setup UI / UI for dev (with docker being one of them)?

Not that I know of. The standalone UI Docker container is mostly just helpful for development.

Shall I do the changes or will you do them?

It's your PR, so feel free to make the changes. But if you just want it added quickly, I’m happy to handle it too.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3430      +/-   ##
=============================================
+ Coverage      59.75%   59.79%   +0.05%     
  Complexity       112      112              
=============================================
  Files           2870     2870              
  Lines         124042   124042              
  Branches        9298     9298              
=============================================
+ Hits           74111    74162      +51     
+ Misses         47150    47088      -62     
- Partials        2781     2792      +11     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@da-Kai da-Kai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @janklostermann,

Thanks, this looks much better! I have just a few minor improvements and a small bugfix.

Comment thread doc/modules/ROOT/pages/gettingstarted.adoc Outdated
Comment thread tools/docker/ui/docker-compose.yml
Comment thread doc/modules/ROOT/pages/ui/deploy.adoc Outdated
@janklostermann
Copy link
Copy Markdown
Contributor Author

Yesterday I found out that the above docker-compose.yml works under Windows as dev machine (where I tested it before the PR), but not under WSL2/Linux.
WSL2/Linux is quite tricky: After trying various paths using standard docker & network concepts, the only one working was using the explicit use of the IP address of the WSL2 in the docker-compose.yml, Which as a result needs a shell script to keep the process simple, automatic and fault resistant.
I am still working on it, to simplify it and provide a good understandable documentation.
Unfortunately I cannot test it on pure Linux or Mac myself. (I guess it should be identical to Windows and just WSL2/Linux needs a workaround due to its system in system architecture.)
Summary: There is more to come for this PR, beyond the port clarification.

Copy link
Copy Markdown
Contributor

@da-Kai da-Kai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @janklostermann,
thanks for your adjustments, i see you extended your PR.

Comment thread tools/docker/ui/docker-compose.yml
Comment thread tools/docker/ui/README.md Outdated
Comment thread tools/docker/ui/README.md
Comment thread tools/docker/ui/README.md Outdated
Comment thread tools/docker/ui/README.md Outdated
Comment thread tools/docker/ui/README.md Outdated
Comment thread tools/docker/ui/start-dev-ui-wsl.sh
Comment thread tools/docker/ui/start-dev-ui-wsl.sh
Comment thread tools/docker/ui/start-dev-ui-wsl.sh
Comment thread tools/prepare-commit.sh Outdated
Copy link
Copy Markdown
Contributor

@da-Kai da-Kai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @janklostermann,
i noticed two minor points that could simplify your script.

Comment thread tools/docker/ui/start-dev-ui-wsl.sh Outdated
Comment thread tools/docker/ui/start-dev-ui-wsl.sh Outdated
Comment thread tools/docker/ui/start-dev-ui-wsl.sh Outdated
@da-Kai da-Kai requested a review from sfeilmeier November 24, 2025 15:57
Copy link
Copy Markdown
Contributor

@sfeilmeier sfeilmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sfeilmeier sfeilmeier merged commit 4c46afc into OpenEMS:develop Nov 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants