Merged
Conversation
Member
"spatial": {
"location": {
"address": "",
"@id": "",
"latitude": "",
"longitude": "" },
"extent": {
"name": "",
"@id": "",
"boundingBox": [,,,],
"resolutionValue": "",
"resolutionUnit": "",
"crs": ""}} |
Member
"spatial": {
"location": {
"address": "Rudower Chaussee 12, 12489 Berlin",
"@id": "https://www.wikidata.org/wiki/Q77077223",
"latitude": "52.432822",
"longitude": "13.5351004" },
"extent": {
"name": null,
"@id": null,
"boundingBox": null,
"resolutionValue": null,
"resolutionUnit": null,
"crs": null}} |
Member
"spatial": {
"location": {
"address": null,
"@id": null,
"latitude": null,
"longitude": null },
"extent": {
"name": "Berlin",
"@id": "https://www.wikidata.org/wiki/Q64",
"boundingBox": [13.08825, 52.33859, 13.76104, 52.6754],
"resolutionValue": "100",
"resolutionUnit": "m",
"crs": "EPSG:4326"}}[minLon (W), minLat (S), maxLon (E), maxLat (N)] |
Member
"spatial": {
"location": {
"address": null,
"@id": null,
"latitude": null,
"longitude": null },
"extent": {
"name": "Germany",
"@id": "https://www.wikidata.org/wiki/Q183",
"boundingBox": null,
"resolutionValue": null,
"resolutionUnit": "federal state",
"crs": null}} |
…EnergyPlatform/metadata into feature-178-enhance-spatial-section
Ludee
approved these changes
Oct 22, 2024
Member
Ludee
left a comment
There was a problem hiding this comment.
Nice concept! Thanks a lot @jh-RLI and @christian-rli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
This PR enhances the spatial information of the oemetadata. It includes new keys for extensive spatial information which need to be discussed further. This includes fields for boundingBox to better describe the extend of the data and also crs information for better reusability of the data.
The "extent" field was reworked to be able to link to external resources that define region names like "Europe" and provide additional information. An @id key was introduced.
The "resolution" was also reworked to make the information more machine readable and also more clear to the user as fields that must hold non atomic information seems to raise confusion as the use case is not well specified.
The original objective of this PR is to resolve the "location" key and introduce more explicit "lat" "lon" key. To keep the human readable address information i suggest to add a address field.
Type of change (CHANGELOG.md)
Updated
Workflow checklist
Automation
Closes #178
PR-Assignee
Reviewer