Conversation
jh-RLI
requested changes
Nov 13, 2024
Contributor
jh-RLI
left a comment
There was a problem hiding this comment.
once the changes with the UTF-8 encoding is done please regenerate the example :)
…etadata into feature-219-example
Contributor
|
Hm for some reason my requested changes do not resolve the issue with the unexpected symbol in special strings. |
Contributor
|
Okay i think you might have some issue on your machine, maybe you open this BOM in the json. When i use the script to regenerate the example.json the symbols are correct. Still, there appears to be a strange issue with the metadata import that is raised after the generation is complete. #The generation is done and then this exception is raised:
ntology/oeo/OEO_00000350'}], 'valueReference': [{'value': None, 'name': None, '@id': None}]}, {'name': 'geom', 'description': 'Geometry', 'type': 'geometry(Point, 4326)', 'nullable': True, 'unit': None, 'isAbout': [{'name': 'spatial region', '@id': 'https://openenergy-platform.org/ontology/oeo/BFO_0000006'}], 'valueReference': [{'value': None, 'name': None, '@id': None}]}]' in metadata/v20/v20/example.json
Traceback (most recent call last):
File "/home/jh/github/oemetadata/metadata/v20/v20/build_source/scripts/generate_example_from_schema.py", line 262, in <module>
test_oemetadata_schema_should_validate_oemetadata_example(json_data)
File "/home/jh/github/oemetadata/metadata/v20/v20/build_source/scripts/generate_example_from_schema.py", line 214, in test_oemetadata_schema_should_validate_oemetadata_example
from metadata.v20.v20.schema import OEMETADATA_V20_SCHEMA
ModuleNotFoundError: No module named 'metadata.v20' |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
The schema.json only provides a single example. We have a nice example available in the previous versions. There is only the nullable missing. We could add some extra code to extend the example and add it to the example.json. We are missing a better example for the table resources schema.
Originally posted by @jh-RLI in #216 (comment)
Type of change (CHANGELOG.md)
Added
Workflow checklist
Automation
Closes #219
PR-Assignee
Reviewer