Conversation
Ludee
added
type: enhancement ⚙️
jh-RLI
approved these changes
Jan 14, 2025
Contributor
jh-RLI
left a comment
jh-RLI
left a comment
There was a problem hiding this comment.
Looks good and seems to work.
We will have to re-evaluate the workflows during the next release. But it should work since it comes from the super repository.
I haven't checked all the cardinality indicators yet. But it seems to be fine. Maybe we could also add a UML diagram to show properties and their cardinality with a better overview.
BTW: I liked my pypi publish workflows more because of the icons :P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
Update documentation with mike.
Comment: Merge other PR first!
Type of change (CHANGELOG.md)
Changed
Workflow checklist
Automation
Closes #204
PR-Assignee
Reviewer