Skip to content

Conversation

@Ludee
Copy link
Member

@Ludee Ludee commented Feb 17, 2025

No description provided.

@Ludee Ludee added part: github :octocat: Improvement of the organisation or repo priority: critical 🔥 Critical priority type: release 🚀 Release procedure status: completed ✔️ Task has been completed labels Feb 17, 2025
@Ludee Ludee requested a review from jh-RLI February 17, 2025 11:29
@Ludee Ludee self-assigned this Feb 17, 2025
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added https://raw.githubusercontent.com/OpenEnergyPlatform/oemetadata/production/oemetadata/v10/v130/schema.json

but the url should be like
https://raw.githubusercontent.com/OpenEnergyPlatform/oemetadata/production/metadata/v1/v130/schema.json

thats why the test are failing.

At lest the v10 must become a v1 the rest will work out once the oemetadata directory is available in production on github

Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url in latest/schema.json should point to the latest directory instead.

"$id": "https://raw.githubusercontent.com/OpenEnergyPlatform/oemetadata/production/oemetadata/v2/v20/schema.json",

@Ludee Ludee marked this pull request as ready for review February 17, 2025 13:23
@Ludee Ludee requested a review from jh-RLI February 17, 2025 13:25
@Ludee
Copy link
Member Author

Ludee commented Feb 17, 2025

All scripts are working and tests pass. Please approve PR

Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, alot of changes, so we will see if i overlooked anything during the review ;)

@Ludee Ludee merged commit 07b33f9 into production Feb 17, 2025
5 checks passed
@Ludee Ludee deleted the release-v2.0.3 branch February 17, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part: github :octocat: Improvement of the organisation or repo priority: critical 🔥 Critical priority status: completed ✔️ Task has been completed type: release 🚀 Release procedure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants