611 multiple mastr download links #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can now also create versions from before and after the current one.
nesnoj
approved these changes
Apr 4, 2025
Collaborator
nesnoj
left a comment
nesnoj
left a comment
There was a problem hiding this comment.
Nice, thx @FlorianK13 !
I just adjusted some small things.
I guess the failing test related to "TechnologieFlugwind" is subject of #607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
Around the time of new releases, the MaStR version number in the download link might be wrong. This PR adds some robustness by also checking download links with the MaStR version that was used before the current one and version that will be used next.
Old: Only check Download link for 23.1
New. First check 23.1, then check 22.2, then check 23.2