Feat remove ied duplicates issue#146
Open
stee-re wants to merge 4 commits intoOpenEnergyTools:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #121
Summary
When multiple IEDs reference the same LNode, removing those IEDs sequentially can result in duplicate LNode
entries with
iedName="None". This PR adds an option to detect and remove such duplicates instead ofcreating redundant entries, by default. Callers can use the options to prevent this happening:
Changes
tIED/removeIED.ts:RemoveIedOptionsinterface with aremoveLNodesflag (defaults totrue)lNodeKey()helper to compute a unique key per LNoderemoveLNodesistrue(default), duplicate LNodes already set to"None"are removed ratherthan duplicated
removeLNodesisfalse, LNodes are only updated to"None"(previous behaviour)index.ts: ExportedRemoveIedOptionstypetIED/removeIED.spec.ts: Added tests for duplicate removal and opt-out behaviourtIED/removeIED.testfile.ts: Added test fixture with duplicate LNode scenario.gitignore: Added IDE and build artifact patterns