Conversation
Collaborator
|
@cursor review |
Collaborator
Author
|
Just FYI @ErlisLushtaku I reviewed this code already with Claude, I think it is ready for human review :-) |
Collaborator
Will give it the human review soon, was just testing some features of cursor if it's any good. It's not working on others' PRs apparently 😄 |
Collaborator
ErlisLushtaku
left a comment
ErlisLushtaku
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR David. I had mostly some questions to clarify, and a couple of comments.
ErlisLushtaku
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several people are using this script to compute ELO ratings, it would be better to have it supported in mainline.
We will have several improvements based on @kargibora 's work to improve the accuracy of the estimation and the confidence interval.