Changed submergence calculation and added additional rod outputs for input file #2946
Conversation
…Length) to average (VOFsum/RodLength) due to some orientations not being consider submerged. Added more outputs for rods in the input file for additional analysis of data (Dp, Ap …).
|
This is a re-opening of the #2943 pull request, but with a cleaner history. |
| IF ( scan( LineOutString, 'd') > 0 ) m%RodList(l)%OutFlagList(15) = 1 ! Segment strain rate | ||
| ! Extended flags outputs | ||
| IF ( scan( LineOutString, 'A') > 0 ) m%RodList(l)%OutFlagList(16) = 1 ! Tangential fluid inertia force (Ap) | ||
| IF ( scan( LineOutString, 'a') > 0 ) m%RodList(l)%OutFlagList(17) = 1 ! Axial fluid inertia force (Aq) |
There was a problem hiding this comment.
Change from axial to tangential to stay consistent
modules/moordyn/src/MoorDyn.f90
Outdated
| IF ( scan( LineOutString, 's') > 0 ) m%RodList(l)%OutFlagList(14) = 1 ! Segment strain | ||
| IF ( scan( LineOutString, 'd') > 0 ) m%RodList(l)%OutFlagList(15) = 1 ! Segment strain rate | ||
| ! Extended flags outputs | ||
| IF ( scan( LineOutString, 'A') > 0 ) m%RodList(l)%OutFlagList(16) = 1 ! Tangential fluid inertia force (Ap) |
There was a problem hiding this comment.
Ap is the transverse fluid inertia force, not tangential
modules/moordyn/src/MoorDyn.f90
Outdated
| IF ( scan( LineOutString, 's') > 0 ) m%RodList(l)%OutFlagList(14) = 1 ! Segment strain | ||
| IF ( scan( LineOutString, 'd') > 0 ) m%RodList(l)%OutFlagList(15) = 1 ! Segment strain rate | ||
| ! Extended flags outputs | ||
| IF ( scan( LineOutString, 'A') > 0 ) m%RodList(l)%OutFlagList(16) = 1 ! Tangential fluid inertia force (Ap) |
There was a problem hiding this comment.
Ap is the transverse fluid inertia force, not tangential
modules/moordyn/src/MoorDyn_IO.f90
Outdated
| END DO | ||
| END IF | ||
|
|
||
| ! Node Axial fluid inertia force |
There was a problem hiding this comment.
Change from axial to tangential in comment
modules/moordyn/src/MoorDyn_IO.f90
Outdated
| END DO | ||
| END IF | ||
|
|
||
| ! Node Tangential fluid inertia force |
There was a problem hiding this comment.
Change comment to transverse fluid inertial force. The p in Ap indicates the transverse direction
modules/moordyn/src/MoorDyn_IO.f90
Outdated
| END DO | ||
| END IF | ||
|
|
||
| ! Node Axial fluid inertia force |
There was a problem hiding this comment.
These forces seem to be indented compared to the code above, if so can you remove the extra space to have them align?
RyanDavies19
left a comment
RyanDavies19
left a comment
There was a problem hiding this comment.
Need to update r-test for new submergence output. Do not merge until r-test updates are complete
|
r-test pr: OpenFAST/r-test#165 |
|
MD regression tests are failing due to the r-test pointer being out of date. Since that is on @KylerF229's branch, we'll merge this with failing tests, then update the pointer. |
3 participants
Tests md_float, md_waterkin2 and md_waterkin3 will fail due to the new submergence calculation.
Feature or improvement description
Submergence calculation change from length wise (h0/RodLength) to average (VOFsum/RodLength) due to some orientations not being consider submerged.
Added more outputs for rods in the input file for additional analysis of data to compare with C version:
Tangential drag forces (Ap)
Axial fluid inertia force (Aq)
Transverse drag forces (Dp)
Tangential drag forces (Dq)
Related issue, if one exists
Impacted areas of the software
MoorDyn
Additional supporting information
Test results, if applicable