HD: Fixed a bug with PtfmRefztRot #3141
Merged
+12
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1st body is rotated according to PtfmRefztRot when NBodyMod=1
andrew-platt
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
Previously, when
NBodyMod=1, only the potential-flow wave excitation of the first body is rotated according toPtfmRefztRot. This bug is now fixed.Note that this bug only affected the results when
NBodyMod=1,NBody>1, andPtfmRefztRot/=0for the second body and onward. This combination of user inputs is rarely encountered.Impacted areas of the software
HydroDyn
Test results, if applicable
No change to existing test results.