Skip to content

FastInterpolations bump and fix#243

Merged
logan-nc merged 3 commits into
developfrom
bugfix/periodicbc-revert-checkfalse
May 22, 2026
Merged

FastInterpolations bump and fix#243
logan-nc merged 3 commits into
developfrom
bugfix/periodicbc-revert-checkfalse

Conversation

@matt-pharr
Copy link
Copy Markdown
Collaborator

Closes #240.

matt-pharr and others added 3 commits May 20, 2026 14:59
… cubic interpolation calls, bump to = 0.4.10
…truction sites

The PeriodicBC(endpoint=:inclusive) validator in FastInterpolations >=0.4.6
still rejects 2D rzphi/eqfun/flux arrays whose periodic-axis endpoint drifts
by machine epsilon from the start slice. Explicitly close the endpoint
(data[:, end, :] .= data[:, 1, :]) before each 2D cubic_interp build so the
strict validator stays enabled instead of relying on check=false.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@matt-pharr matt-pharr requested a review from logan-nc May 21, 2026 20:05
@logan-nc logan-nc merged commit 6589533 into develop May 22, 2026
5 checks passed
@logan-nc logan-nc deleted the bugfix/periodicbc-revert-checkfalse branch May 22, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PeriodicBC endpoint validator triggered by machine-epsilon mismatches; use targeted endpoint closure instead of blanket check=false

2 participants