Fix for bug in Ribbon-Module, where query strings are not properly encod...#100
Merged
allenxwang merged 1 commit intoOpenFeign:masterfrom Mar 24, 2014
Merged
Fix for bug in Ribbon-Module, where query strings are not properly encod...#100allenxwang merged 1 commit intoOpenFeign:masterfrom
allenxwang merged 1 commit intoOpenFeign:masterfrom
Conversation
|
feign-pull-requests #136 SUCCESS |
Author
|
Any news on this? =) |
allenxwang
pushed a commit
that referenced
this pull request
Mar 24, 2014
Fix for bug in Ribbon-Module, where query strings are not properly encod...
Contributor
|
Looks good to me. Sorry about the delay. |
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Fix for bug in Ribbon-Module, where query strings are not properly encod...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for bug in Ribbon-Module, where query strings are not properly encoded.
For example:
GET /path?parameter=value with space
Should be
GET /path?parameter=value+with+space
But was
GET /path?parameter=value with space
And I was like NOOOOOOOO!