Skip to content

Introduces feign.Param to annotate template parameters#145

Merged
codefromthecrypt merged 1 commit intomasterfrom
adrian.named-to-param
Jan 26, 2015
Merged

Introduces feign.Param to annotate template parameters#145
codefromthecrypt merged 1 commit intomasterfrom
adrian.named-to-param

Conversation

@codefromthecrypt
Copy link
Contributor

Feign 8.x will no longer support Dagger, nor interfaces annotated with javax.inject.@Named. Users must migrate from javax.inject.@Named to feign.@Param via Feign v7.1+ before attempting to update to Feign 8.0.

For example, the following uses @Param as opposed to @Named to annotate template parameters.

interface GitHub {
  @RequestLine("GET /repos/{owner}/{repo}/contributors")
  List<Contributor> contributors(@Param("owner") String owner, @Param("repo") String repo);
}

Feign 8.x will no longer support Dagger, nor interfaces annotated with `javax.inject.@Named`. Users must migrate from `javax.inject.@Named` to `feign.@Param` via Feign v7.1+ before attempting to update to Feign 8.0.

For example, the following uses `@Param` as opposed to `@Named` to annotate template parameters.

```java
interface GitHub {
  @RequestLine("GET /repos/{owner}/{repo}/contributors")
  List<Contributor> contributors(@param("owner") String owner, @param("repo") String repo);
}
```
@cloudbees-pull-request-builder

NetflixOSS » feign » feign-pull-requests #16 SUCCESS
This pull request looks good

codefromthecrypt pushed a commit that referenced this pull request Jan 26, 2015
Introduces feign.Param to annotate template parameters
@codefromthecrypt codefromthecrypt merged commit 62cbe19 into master Jan 26, 2015
@codefromthecrypt codefromthecrypt deleted the adrian.named-to-param branch January 26, 2015 06:03
@cloudbees-pull-request-builder

NetflixOSS » feign » feign-pull-requests #17 SUCCESS
This pull request looks good

@codefromthecrypt codefromthecrypt added this to the 7.1.0 milestone Jan 26, 2015
velo pushed a commit that referenced this pull request Oct 8, 2024
Introduces feign.Param to annotate template parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants