Retain scheme in LBClient.RibbonRequest URI - fixes #183

[bstick12]

No description provided.

[cloudbees-pull-request-builder]

NetflixOSS » feign » feign-pull-requests #53 SUCCESS
This pull request looks good

[codefromthecrypt]

Thanks for the help. I think we need a test for this, right? Can you port something like this into the ribbon test? That way future work doesn't undo yours. https://github.com/Netflix/feign/blob/master/core/src/test/java/feign/client/DefaultClientTest.java#L119

[cloudbees-pull-request-builder]

NetflixOSS » feign » feign-pull-requests #56 SUCCESS
This pull request looks good

[bstick12]

Added a test to check the https connection works

[codefromthecrypt]

nit I don't think this comment is required. the commit log already says this, and the need for this feature is obvious.

[codefromthecrypt]

hypernit on comment, also I'm trying to help us get more readable commit log. can you switch to this form?
Note using retains vs retain makes the commit log look like.

"this commit retains scheme in LBClient.RibbonRequest"

Retains scheme in LBClient.RibbonRequest URI

Before this change, we were dropping scheme, which prevented use of https.

closes #183
``

[cloudbees-pull-request-builder]

NetflixOSS » feign » feign-pull-requests #58 SUCCESS
This pull request looks good