Skip to content

Fix false positive tests in ksp-codegen by correcting assertContainAll logic#1573

Merged
velo merged 1 commit intoOpenFeign:masterfrom
justdeok:ksp-codegen-test
Feb 12, 2026
Merged

Fix false positive tests in ksp-codegen by correcting assertContainAll logic#1573
velo merged 1 commit intoOpenFeign:masterfrom
justdeok:ksp-codegen-test

Conversation

@justdeok
Copy link
Copy Markdown
Contributor

Summary

Fixed a logic error in assertContainAll where it was validating the expected string against itself instead of the actual output.

Key Changes

  • Corrected the receiver in assertContainAll from other to this.
  • Updated mismatched tests accordingly.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (115ed29) to head (5099b57).
⚠️ Report is 23 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1573    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         813     838    +25     
  Lines       31466   31795   +329     
  Branches     3614    3622     +8     
=======================================
- Misses      31466   31795   +329     
Flag Coverage Δ
cubrid 0.00% <ø> (?)
db2 0.00% <ø> (?)
embedded 0.00% <ø> (?)
examples 0.00% <ø> (?)
firebird 0.00% <ø> (?)
mongodb 0.00% <ø> (?)
mysql 0.00% <ø> (?)
oracle 0.00% <ø> (?)
postgresql 0.00% <ø> (?)
test 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@velo velo requested a review from IceBlizz6 February 6, 2026 19:15
@velo velo merged commit 2119c39 into OpenFeign:master Feb 12, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants