fix(apt): circular dependencies are not problematic

[Athou]

Hello,

Renovate is trying to update QueryDSL from 7.1 to 7.2 here but a warning is emitted. The build does not pass because warnings are treated as errors during the build of CommaFeed.

The warning is

[WARNING] [QueryDSL] Circular Q-class references detected.
  This may cause class initialization deadlock in multi-threaded environments.
  
  Detected cycles:
    (1) FeedSubscription → FeedCategory → FeedCategory
  
  To avoid deadlock, consider:
    (1) Removing the bidirectional association on one side.
    (2) Pre-initializing Q-classes in a single thread before handling requests (e.g. via @PostConstruct).
    (3) Using 'new QClass("alias")' instead of static field access in your repositories.

I think this is caused by my self-referencing FeedCategory class where the parent field is referencing its own class.

@Entity
@Table(name = "FEEDCATEGORIES")
@SuppressWarnings("serial")
@Getter
@Setter
public class FeedCategory extends AbstractModel {

	@Column(length = 128, nullable = false)
	private String name;

	@ManyToOne(fetch = FetchType.LAZY)
	@JoinColumn(nullable = false)
	private User user;

	@ManyToOne(fetch = FetchType.LAZY)
	private FeedCategory parent;

	private boolean collapsed;

	private int position;

}

I think this is a false positive, hence the pull request, but let me know if it is the actual expected behavior and how to fix this warning if it is the case 🙂

Also pinging @o54711254 as the original author of #1739.

[o54711254]

Hi @Athou, thanks for catching this and opening the PR.
You're right — my cycle detection logic didn't account for self-referencing entities, and I missed this edge case.
Your fix looks correct. Excluding self-loops from cycle detection is the right approach here.