Publish querydsl-bom as a real module so it auto-deploys to Central#1763
Merged
Conversation
…tically Signed-off-by: Marvin Froeder <velo.br@gmail.com>
Signed-off-by: Marvin Froeder <velo.br@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
querydsl-bomwas missing from Maven Central for 7.2 (see #1444), while every other 7.2 artifact was present. Root cause: the BOM is produced bysundr-maven-plugin:generate-bom, but sundr's template emits no<build>, so its self-deploy never goes through thecentral-publishing-maven-pluginportal publisher. Every prior BOM (7.1, …) had to be uploaded manually. The generated BOM also wrongly includedquerydsl-apt-test, which is excluded from Central deploy.(7.2 BOM has been published manually to unblock users; this PR fixes the build so it never happens again.)
Fix
Keep sundr as the generator (preserving module auto-discovery), but make the BOM a real committed module that publishes through the same path as every other artifact:
src/main/resources/bom-template.xml.vm— custom sundr template emitting a parent-based module pom (inherits thereleaseprofile: gpg + central-publishing) instead of a standalone pom.querydsl-bom/pom.xml— the generated BOM, committed and wired into<modules>; it now deploys likequerydsl-core.<goals>excludeinstall/deploy— sundr only writes the file; it no longer attempts its broken self-deploy.*:querydsl-bom(no self-reference) and*:querydsl-apt-test(not deployed to Central).Regenerating when modules change
Verified
querydsl-bomvalidates and builds in the reactor.-Preleasethe module is gpg-signed and central-publishing engages (same path asquerydsl-core).sortpomis idempotent on the generated pom, so the regenerate→commit workflow is stable.