Merge unit tests#486
Merged
Merged
Conversation
Collaborator
Author
|
Ok, the action is working and the work is rebased. But tests are failing - mostly I think because an api key is needed on tne anthropic client. This shouldn't really be needed so we'll investigate solutions a bit later. |
Collaborator
Author
|
Oh nice, the tests are working! I've just had to be a bit more selective about the tests we run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rebases #479 against latest main and add a couple of tweaks ready for merging, including: