feat: ignore top objects in several transforms#1064
Merged
josephjclark merged 1 commit intoignore-top-object-add-importfrom Oct 10, 2025
Merged
feat: ignore top objects in several transforms#1064josephjclark merged 1 commit intoignore-top-object-add-importfrom
josephjclark merged 1 commit intoignore-top-object-add-importfrom
Conversation
| import { namedTypes as n } from 'ast-types'; | ||
| import { NodePath } from 'ast-types/lib/node-path'; | ||
|
|
||
| const IgnoreRules = (path: NodePath<n.Expression>) => { |
Collaborator
Author
There was a problem hiding this comment.
Our true and false stuff started confusing me a lot today
Collaborator
There was a problem hiding this comment.
Yeah, it's a problem. I'll say this: if we do any more compiler work, we need to make those booleans consistent as a first step.
I'm hoping we can merge down from here, I'm just about to run some tests
Collaborator
|
@doc-han this looks great - Putting all these changes together is an amazing result and a really solid performance boost. Thank you! |
josephjclark
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use openfn compile --trace## Short Description
A one or two-sentence description of what this PR does.
Fixes #
Implementation Details
A more detailed breakdown of the changes, including motivations (if not provided in the issue).
QA Notes
List any considerations/cases/advice for testing/QA here.
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Release branch checklist
Delete this section if this is not a release PR.
If this IS a release branch:
pnpm changeset versionfrom root to bump versionspnpm installpnpm changeset tagto generate tagsgit push --tagsTags may need updating if commits come in after the tags are first generated.