worker: fix an edge case where a run can be lost between claim and st…#1112
Merged
josephjclark merged 2 commits intorelease/nextfrom Nov 3, 2025
Merged
worker: fix an edge case where a run can be lost between claim and st…#1112josephjclark merged 2 commits intorelease/nextfrom
josephjclark merged 2 commits intorelease/nextfrom
Conversation
…art if destroy() is aclled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that when destroying a server, any active claims will be properly processed before shutdown. There's an edge case in #910 where claim finishes but the run doesn't actually start.
Silly error really - an async function in an
each()loop is not async!This was passing in unit tests because JWT verification was disabled and so destroy was running synchronously. It's the async await that does the harm.
Short Description
A one or two-sentence description of what this PR does.
Fixes #910
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy