Skip to content

deploy: support webhook_reply and cron_cursor_job#1344

Merged
josephjclark merged 3 commits into
mainfrom
support-webhook-reply
Apr 1, 2026
Merged

deploy: support webhook_reply and cron_cursor_job#1344
josephjclark merged 3 commits into
mainfrom
support-webhook-reply

Conversation

@midigofrank
Copy link
Copy Markdown
Contributor

@midigofrank midigofrank commented Mar 31, 2026

Support new keys in sync v1

Sync v2 not fully supported

May cause breaking changes in sync for older apps with this CLI version - see release notes.

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

@github-project-automation github-project-automation Bot moved this to New Issues in Core Mar 31, 2026
@josephjclark
Copy link
Copy Markdown
Collaborator

Notes from call:

  • deploy needs a major version bump because it;ll break against some lightning versions
  • CLI needs a minor bump and a clear warning in release notes

@josephjclark
Copy link
Copy Markdown
Collaborator

I will test this with deploy v2 to ensure it works (I think it will)

@josephjclark
Copy link
Copy Markdown
Collaborator

I've just run a couple of tests against staging with v2. It looks like the new keys aren't being downloaded to the project.yaml. That's a bit of a surprise to me - I may need to add a fix

@josephjclark
Copy link
Copy Markdown
Collaborator

Right so that was a problem with staging actually

It looks like v2 will sync the project.yaml correctly - it looks just how I expect

But in v2 sync we need to consider:
a) exposing the new trigger fields in workflow.yaml
b) Updating the version hash (in lightning too)

I don't think I have time to do this today. Or actually this week. So I'm going to open up a new issue for v2 sync

@josephjclark josephjclark marked this pull request as ready for review April 1, 2026 13:24
@josephjclark josephjclark merged commit 267cc15 into main Apr 1, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from New Issues to Done in Core Apr 1, 2026
@josephjclark josephjclark deleted the support-webhook-reply branch April 1, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants