Skip to content

feat: override endpoint with one from openfn.yaml#1385

Merged
josephjclark merged 4 commits intomainfrom
sync-v2-endpoint
Apr 20, 2026
Merged

feat: override endpoint with one from openfn.yaml#1385
josephjclark merged 4 commits intomainfrom
sync-v2-endpoint

Conversation

@doc-han
Copy link
Copy Markdown
Collaborator

@doc-han doc-han commented Apr 20, 2026

Short Description

Updates project pull so that the endpoint provided in openfn.yaml will be respected

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

@github-project-automation github-project-automation bot moved this to New Issues in Core Apr 20, 2026
Comment on lines +30 to +35
// override endpoint with one from openfn.yaml
const config = yamlToJson(await fs.readFile(v2ConfigPath, 'utf-8'));
if (config?.project?.endpoint) {
config.endpoint = config.project.endpoint;
}

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this, redirects to the sync v2 don't pick up the endpoint coming from openfn.yaml

@josephjclark josephjclark merged commit 954d398 into main Apr 20, 2026
1 check was pending
@github-project-automation github-project-automation bot moved this from New Issues to Done in Core Apr 20, 2026
@josephjclark josephjclark deleted the sync-v2-endpoint branch April 20, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants