Skip to content

Worker: Fix batch events being dropped#1389

Merged
josephjclark merged 5 commits intorelease/nextfrom
fix-events-order
Apr 24, 2026
Merged

Worker: Fix batch events being dropped#1389
josephjclark merged 5 commits intorelease/nextfrom
fix-events-order

Conversation

@josephjclark
Copy link
Copy Markdown
Collaborator

@josephjclark josephjclark commented Apr 23, 2026

Short Description

Relates to #1072 but it's actually a different fix

Implementation Details

This is a very claude driven solution. The whole algorithm is bit too claudey. I'm tempted to rethink the whole thing but maybe that's even riskier?

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

@github-project-automation github-project-automation Bot moved this to New Issues in Core Apr 23, 2026
@josephjclark
Copy link
Copy Markdown
Collaborator Author

So this isn't the issue we're seeing in production because
a) this only affects batch logs
b) batch logs is off in production

So this is worth pushing through but its a fix for later, not a fix for now

@josephjclark josephjclark changed the base branch from main to release/next April 24, 2026 11:00
@josephjclark josephjclark changed the title Worker: Fix events being dropped Worker: Fix batch events being dropped Apr 24, 2026
@josephjclark josephjclark marked this pull request as ready for review April 24, 2026 11:04
@josephjclark
Copy link
Copy Markdown
Collaborator Author

Try it out I guess!

@josephjclark josephjclark merged commit 4e2f3df into release/next Apr 24, 2026
1 check was pending
@github-project-automation github-project-automation Bot moved this from New Issues to Done in Core Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants