Error state of (node/edges) not persisting in collab-editor

[doc-han]

Describe the bug When I change the content of a node/edge to something that will error, the error doesn't seem to persist.
eg.

1. have two users on the same workflow and also on the form. eg. the JobForm or EdgeForm
2. user1 should change the value of the form to an error state.
3. you'll notice that the error doesn't persist. this is because user2 just being present cleans up the error state

NOTE: Please pay attention to comments below this issue

Version number The version of Lightning you have seen the bug on.

If you're running on a tagged version, include the number: vX.Y.Z

If you're running locally with an unreleased version, the commit sha: 84b1bdc

I have reproduced this locally on main:

• Yes
• No

To Reproduce Steps to reproduce the behavior:

from description.

Expected behavior A clear and concise description of what you expected to
happen.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

[doc-han]

Additional context:
This problem happens under a very special scenario.

• when both users are on the same input. then one of them takes the input into an invalid/error state

Actually, when they both have the same form open. eg. the JobForm

[doc-han]

Detailed explanation of the issue.

we have

1. a local form
2. a server that syncs form state to all other people on the workflow

Error states
we give the local form's error state precedence.
Hence,

There's an error from the server but upon changing my local form, the error is gone, we then push back an empty error state to the server. This works for a user who is actively updating the form.

What about a user who isn't actively updating the form but just on the form?
Scenario
There's no error on a form. we have 2 users connected. user1 and user2

user1 - creates an error on their form, hence their error state takes precedence over the no error from the server, pushes the error to the server.
user2 - at the time of receiving the error state from user1 through the server, my form is actually with no errors, hence it also takes precedence and ignores the error coming from the server. we then push no error back to the server.

This clears the error state from the server making no error ever persist if there are more than 1 user on a form.

[doc-han]

Solution: a new strategy for merging errors

when user is editing	when user is not editing
local form errors > server errors	server errors > local form errors

[doc-han]

Seem to be bottlenecked here by our 500ms debounce for sending client errors to server. I think this was in-place to reduce amount of server calls.

[doc-han]

A cascading effect
At this point in time, we don't have any onMount validation handler for forms. Hence, once errors are cleared due to this bug, they don't show up even after refresh.

[doc-han]

Good case
Even tho this issue causes error states to be off when multiple users are on the same form, users will still be informed of the actual error state once they try saving. Hence, this doesn't seem like a a very critical bug.

[josephjclark]

@doc-han and @stuartc decided that the bug does need fixing, but because it's going to be complex we're pushing it back a bit