-
Notifications
You must be signed in to change notification settings - Fork 58
feat: add sandbox banners to workflow editor #3824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3824 +/- ##
==========================================
+ Coverage 88.66% 88.79% +0.12%
==========================================
Files 421 421
Lines 18277 18300 +23
==========================================
+ Hits 16206 16249 +43
+ Misses 2071 2051 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add role='alert' attribute for accessibility - Update test assertions to match actual component text
76bd469 to
a92f787
Compare
|
Thanks for getting this up @elias-ba! Great to see something so we can discuss and think through the details. How this looks right now:
Here's the inevitable feedback!
Also - is it too much to show the current |
…aker icon, remove canvas banners, add env chips, make sandbox name bold
c8bb3b5 to
b619401
Compare
Remove assertions for 'Switch to' links (removed per feedback) Update tests to check inspector instead of canvas (banner only in inspector now) All sandbox indicator tests now pass
|
Hey @josephjclark, I implemented all your feedback on this one. Would you mind having another look and let me know ? |
Add tests for env chip in canvas and inspector to improve coverage Tests verify env chip shows with correct content when project has env field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! 🎯


Description
This PR implements visual indicators to clearly show when working in a sandbox environment, addressing the critical safety concern identified that users might modify workflows without realizing they're in a dev/prod sandbox.
Closes #3413
Validation steps
Test banner in sandbox inspector:
Test env chip display:
Test banner NOT on canvas:
Test deep sandbox hierarchies:
Test non-sandbox projects:
Test both editors:
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist