Merged
Conversation
Extract breadcrumb presentation logic from header by:
- Adding breadcrumbs/1 wrapper component (nav/ol structure)
- Adding breadcrumb_items/1 helper for {label, path} tuples
- Replacing breadcrumbs attribute with :breadcrumbs slot
- Removing project attribute (callers now compose project picker)
- Updating all call sites to use new slot-based API
Replace manual show_separator attribute with Tailwind arbitrary variants that automatically hide the separator on the first breadcrumb item. This eliminates error-prone manual management of separator visibility.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4356 +/- ##
==========================================
+ Coverage 89.25% 89.35% +0.10%
==========================================
Files 425 425
Lines 20005 20009 +4
==========================================
+ Hits 17855 17880 +25
+ Misses 2150 2129 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the breadcrumbs attribute with a slot, giving pages full control over their breadcrumb content. This
simplifies the header component by removing internal breadcrumb collection logic and uses CSS selectors to auto-hide
the first separator.