Skip to content

Use distinct action type for API provisioning error message#4427

Merged
midigofrank merged 3 commits intomainfrom
fix/provisioner-error-message
Feb 16, 2026
Merged

Use distinct action type for API provisioning error message#4427
midigofrank merged 3 commits intomainfrom
fix/provisioner-error-message

Conversation

@elias-ba
Copy link
Copy Markdown
Contributor

@elias-ba elias-ba commented Feb 15, 2026

Description

This PR adds a limit_api_provisioning/1 function to VersionControlUsageLimiter and uses it in Provisioner.import_document/4 instead of limit_github_sync/1. This allows to return a context-appropriate error message when provisioning via the API is denied, rather than always returning the GitHub-sync-specific message.

Validation steps

Additional notes for the reviewer

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

…message

The provisioner was using `limit_github_sync` which returns "Github Sync
is not enabled for your plan" even for CLI deploy requests. This adds a
separate `limit_api_provisioning` action type so CLI users see
"Project provisioning via API is not enabled for your plan" instead.

Closes #4426
@github-project-automation github-project-automation Bot moved this to New Issues in Core Feb 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.36%. Comparing base (bf0c5ef) to head (1dee92b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4427      +/-   ##
==========================================
+ Coverage   89.35%   89.36%   +0.01%     
==========================================
  Files         425      425              
  Lines       20090    20094       +4     
==========================================
+ Hits        17951    17957       +6     
+ Misses       2139     2137       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@midigofrank midigofrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@josephjclark
Copy link
Copy Markdown
Collaborator

Nice work @elias-ba . Can I test this locally without having thunderbolt setup? Maybe it's easier if I make a note to run QA against staging?

@midigofrank midigofrank merged commit 17d9430 into main Feb 16, 2026
7 checks passed
@midigofrank midigofrank deleted the fix/provisioner-error-message branch February 16, 2026 15:50
@github-project-automation github-project-automation Bot moved this from New Issues to Done in Core Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants